hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8270) hadoop-daemon.sh stop action is not LSB compliant
Date Wed, 11 Apr 2012 23:47:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252051#comment-13252051
] 

Hadoop QA commented on HADOOP-8270:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12522342/HADOOP-8270.patch.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.fs.viewfs.TestViewFsTrash

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/847//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/847//console

This message is automatically generated.
                
> hadoop-daemon.sh stop action is not LSB compliant
> -------------------------------------------------
>
>                 Key: HADOOP-8270
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8270
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.23.1
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>             Fix For: 2.0.0
>
>         Attachments: HADOOP-8270.patch.txt
>
>
> The following bit of code from hadoop-daemon.sh is not LSB compliant, since
> according to http://refspecs.linuxbase.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html
> a stop action on an already stopped service should return 0.
> {noformat}
>  (stop)
>     if [ -f $pid ]; then
>       if kill -0 `cat $pid` > /dev/null 2>&1; then
>         echo stopping $command
>         kill `cat $pid`
>       else
>         echo no $command to stop
>         exit 1
>       fi
>     else
>       echo no $command to stop
>       exit 1
>     fi
>     ;;
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message