Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Mon, 26 Mar 2012 04:14:52 +0000 (UTC)
From: "Aaron T. Myers (Updated) (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <980651576.15965.1332735292430.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <330737614.30743.1308784130854.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (HADOOP-7416) Allow test-patch to work with cross
 sub-project changes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HADOOP-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron T. Myers updated HADOOP-7416:
-----------------------------------

    Attachment: HADOOP-7416.patch

Here's a patch which partially addresses the issue. This will allow for cross-sub-project patches to apply cleanly, and will comment with a "-0 patch..." in the JIRA comment if this is detected. It *won't* actually run all of the tests from all affected modules. Since that's a substantially more involved change, and since this change should help considerably, I'd like to punt that to a separate JIRA.

I tested this patch by creating a few uni-project and multi-project patches, and running test-patch manually. With this change, test-patch successfully applies and detects cross-sub-project patches.
                
> Allow test-patch to work with cross sub-project changes
> -------------------------------------------------------
>
>                 Key: HADOOP-7416
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7416
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>         Attachments: HADOOP-7416.patch
>
>
> Now that the sub-projects are sub-directories in the same repo, we can make {{test-patch.sh}} not barf on cross-project patches. We would need to make {{smart-apply-patch.sh}} not fail hard when it detects this, and probably make {{test-patch.sh}} run all the validation checks against all affected sub-projects.
> This was inspired by HDFS-1900, which changes a config in Common that's referenced in a bunch of places in HDFS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira