Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Tue, 27 Mar 2012 17:38:28 +0000 (UTC)
From: "Todd Lipcon (Commented) (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <435443733.24317.1332869908787.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <72388769.21461.1332815246340.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-8218) RPC.closeProxy shouldn't throw
 error when closing a mock
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239685#comment-13239685 ] 

Todd Lipcon commented on HADOOP-8218:
-------------------------------------

I'm fine with that, too. Suresh/Tom? Pick your patch, I'll do it. I just want to get something committed today to fix the failing tests.
                
> RPC.closeProxy shouldn't throw error when closing a mock
> --------------------------------------------------------
>
>                 Key: HADOOP-8218
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8218
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc, test
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hadoop-8218.txt, hadoop-8218.txt
>
>
> HADOOP-8202 changed the behavior of RPC.stopProxy() to throw an exception if called on an object which doesn't implement Closeable. Unfortunately, we use mock objects in many test cases, and those mocks don't implement Closeable. This is causing TestZKFailoverController to fail in trunk, for example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira