Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Wed, 28 Mar 2012 04:39:49 +0000 (UTC)
From: "Suresh Srinivas (Commented) (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <1886766084.26847.1332909590308.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <72388769.21461.1332815246340.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-8218) RPC.closeProxy shouldn't throw
 error when closing a mock
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240160#comment-13240160 ] 

Suresh Srinivas commented on HADOOP-8218:
-----------------------------------------

Aaron and Todd, I am not sure why making mock implement Closeable is that hard and deemed to be jumping through the hooops. There are only couple of instance of this. The problem associated with not implementing Closeable is typically caught while writing the unit test it self.

That said, if you guys feel it is such a pain, I am okay with Aaron is suggesting, in the interest of saving time. So I am +1 with what you guys choose, as long as we silently do not ignore failure to stop proxy, in non mock cases.
                
> RPC.closeProxy shouldn't throw error when closing a mock
> --------------------------------------------------------
>
>                 Key: HADOOP-8218
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8218
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc, test
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hadoop-8218.txt, hadoop-8218.txt
>
>
> HADOOP-8202 changed the behavior of RPC.stopProxy() to throw an exception if called on an object which doesn't implement Closeable. Unfortunately, we use mock objects in many test cases, and those mocks don't implement Closeable. This is causing TestZKFailoverController to fail in trunk, for example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira