Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 505E09768 for ; Mon, 5 Mar 2012 21:46:19 +0000 (UTC) Received: (qmail 7906 invoked by uid 500); 5 Mar 2012 21:46:18 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 7856 invoked by uid 500); 5 Mar 2012 21:46:18 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 7754 invoked by uid 99); 5 Mar 2012 21:46:18 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Mar 2012 21:46:18 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Mar 2012 21:46:17 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id A4A58A6BE for ; Mon, 5 Mar 2012 21:45:57 +0000 (UTC) Date: Mon, 5 Mar 2012 21:45:57 +0000 (UTC) From: "Hadoop QA (Commented) (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1645212476.23893.1330983957675.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-8140) dfs -getmerge should process its argments better MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-8140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222633#comment-13222633 ] Hadoop QA commented on HADOOP-8140: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12517127/HADOOP-8140-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/672//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/672//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/672//console This message is automatically generated. > dfs -getmerge should process its argments better > -------------------------------------------------- > > Key: HADOOP-8140 > URL: https://issues.apache.org/jira/browse/HADOOP-8140 > Project: Hadoop Common > Issue Type: Bug > Reporter: arkady borkovsky > Assignee: Daryn Sharp > Attachments: HADOOP-8140-2.patch, HADOOP-8140.patch, Hadoop-1004_1.patch > > > The command only works if its argument is a directory > If the argement is a file or a wildcard, it does nothing without any message. > If not arguments are given, the command fails with a stack dump. > The improved version should: > -- produce an error message in case it cannot perform meaningful action (no argument, or no matching files) > -- copy the files specified by a wildcard expresstion. (A single file is special case of this). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira