Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B9C8990E0 for ; Thu, 29 Mar 2012 21:53:50 +0000 (UTC) Received: (qmail 59992 invoked by uid 500); 29 Mar 2012 21:53:50 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 59959 invoked by uid 500); 29 Mar 2012 21:53:50 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 59951 invoked by uid 99); 29 Mar 2012 21:53:50 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Mar 2012 21:53:50 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Mar 2012 21:53:47 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id A5C1C34BB79 for ; Thu, 29 Mar 2012 21:53:26 +0000 (UTC) Date: Thu, 29 Mar 2012 21:53:26 +0000 (UTC) From: "Todd Lipcon (Commented) (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1604792839.35380.1333058006680.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <694397862.21709.1332822603289.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-8220) ZKFailoverController doesn't handle failure to become active correctly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241836#comment-13241836 ] Todd Lipcon commented on HADOOP-8220: ------------------------------------- The "above" there refers to the fact that {{becomeActive()}} itself logs the error message. I changed the comment to: {code} + // The failure to become active is already logged inside + // becomeActive(). {code} > ZKFailoverController doesn't handle failure to become active correctly > ---------------------------------------------------------------------- > > Key: HADOOP-8220 > URL: https://issues.apache.org/jira/browse/HADOOP-8220 > Project: Hadoop Common > Issue Type: Bug > Components: auto-failover, ha > Affects Versions: 0.23.3, 0.24.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Critical > Attachments: hadoop-8220.txt, hadoop-8220.txt > > > The ZKFC doesn't properly handle the case where the monitored service fails to become active. Currently, it catches the exception and logs a warning, but then continues on, after calling quitElection(). This causes a NPE when it later tries to use the same zkClient instance while handling that same request. There is a test case, but the test case doesn't ensure that the node that had the failure is later able to recover properly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira