Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Sun, 18 Mar 2012 02:52:39 +0000 (UTC)
From: "Aaron T. Myers (Commented) (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <16011790.28801.1332039159659.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-7788) HA: Simple HealthMonitor class to
 watch an HAService
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232132#comment-13232132 ] 

Aaron T. Myers commented on HADOOP-7788:
----------------------------------------

Largely looks good, Todd. A few small comments:

# I don't understand why it's necessary/desirable to set "{{shouldRun = false}}" in the case of an InterruptedException in {{run()}}. When would this method be interrupted except in the case of a call to {{shutdown()}}, which itself sets {{shouldRun}} to false?
# "{{LOG.warn("Transport-level exception trying to monitor health of " + addrToMonitor + ": " + t.getLocalizedMessage());}}" - let's log the full exception stack trace here.
# Seems odd to me that the main method of this class creates a HealthMonitor and calls {{run()}}, instead of calling {{start()}}/{{join()}}.

+1 once these are addressed.
                
> HA: Simple HealthMonitor class to watch an HAService
> ----------------------------------------------------
>
>                 Key: HADOOP-7788
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7788
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: ha
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-7788.txt, hdfs-2524.txt
>
>
> This is a utility class which will be part of the FailoverController. The class starts a daemon thread which periodically monitors an HAService, calling its monitorHealth function. It then generates callbacks into another class when the health status changes (eg the RPC fails or the service returns a HealthCheckFailedException)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira