Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CBF7C924F for ; Thu, 22 Mar 2012 18:36:43 +0000 (UTC) Received: (qmail 28588 invoked by uid 500); 22 Mar 2012 18:36:43 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 28560 invoked by uid 500); 22 Mar 2012 18:36:43 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 28551 invoked by uid 99); 22 Mar 2012 18:36:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Mar 2012 18:36:43 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Mar 2012 18:36:42 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 59A7E3400FF for ; Thu, 22 Mar 2012 18:36:22 +0000 (UTC) Date: Thu, 22 Mar 2012 18:36:22 +0000 (UTC) From: "Eli Collins (Updated) (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1003510449.3680.1332441382368.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <933274554.46681.1331341619507.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eli Collins updated HADOOP-8159: -------------------------------- Target Version/s: 1.1.0, 0.23.3 (was: 1.0.0) Fix Version/s: (was: 1.0.0) Looks great Two nits: - The invalid topo exception references "data node" but can be used for MR too. Can just say "node". - Let's define INVALID_LEVEL = -1 and use that (can put next to DEFAULT_HOST_LEVEL). > NetworkTopology: getLeaf should check for invalid topologies > ------------------------------------------------------------ > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159.005.patch, HADOOP-8159.006.patch, HADOOP-8159.007.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the InnerNode object itself. This results in us getting ClassCastException sometimes when the network topology is invalid. We should have a less confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira