hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8154) DNS#getIPs shouldn't silently return the local host IP for bogus interface names
Date Fri, 09 Mar 2012 04:10:22 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225823#comment-13225823
] 

Hadoop QA commented on HADOOP-8154:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12517675/hadoop-8154-b1.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/692//console

This message is automatically generated.
                
> DNS#getIPs shouldn't silently return the local host IP for bogus interface names
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-8154
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8154
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 0.23.3
>
>         Attachments: hadoop-8154-b1.txt, hadoop-8154.txt
>
>
> DNS#getIPs silently returns the local host IP for bogus interface names. In this case
let's throw an UnknownHostException. This is technically an incompatbile change. I suspect
the current behavior was origininally introduced so the interface name "default" works w/o
explicitly checking for it. It may also be used in cases where someone is using a shared config
file and an option like "dfs.datanode.dns.interface" or "hbase.master.dns.interface" and eg
interface "eth3" that some hosts don't have, though I think silently ignorning this is the
wrong behavior (those hosts should be configured to use a different interface).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message