hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8167) Configuration deprecation logic breaks backwards compatibility
Date Wed, 14 Mar 2012 01:48:38 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228888#comment-13228888
] 

Hadoop QA commented on HADOOP-8167:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12518212/HADOOP-8167.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/708//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/708//console

This message is automatically generated.
                
> Configuration deprecation logic breaks backwards compatibility
> --------------------------------------------------------------
>
>                 Key: HADOOP-8167
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8167
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.24.0, 0.23.3
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>            Priority: Blocker
>             Fix For: 0.23.3
>
>         Attachments: HADOOP-8167.patch
>
>
> The deprecated Configuration logic works as follows:
> For a dK deprecated key in favor of nK:
> * on set(dK, V), it stores (nK,V)
> * on get(dK) it does a reverseLookup of dK to nK and looks for get(nK)
> While this works fine for single set/get operations, the iterator() method that returns
an iterator of all config key/values, returns only the new keys.
> This breaks applications that did a set(dK, V) and expect, when iterating over the configuration
to find (dK, V).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message