hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8218) RPC.closeProxy shouldn't throw error when closing a mock
Date Wed, 28 Mar 2012 05:14:23 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240177#comment-13240177
] 

Hudson commented on HADOOP-8218:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2012 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2012/])
    HADOOP-8218. RPC.closeProxy shouldn't throw error when closing a mock. Contributed by
Todd Lipcon. (Revision 1306164)

     Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306164
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HealthMonitor.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/DummyHAService.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestFailoverController.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MockitoUtil.java

                
> RPC.closeProxy shouldn't throw error when closing a mock
> --------------------------------------------------------
>
>                 Key: HADOOP-8218
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8218
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc, test
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>             Fix For: 0.23.3, 0.24.0
>
>         Attachments: hadoop-8218.txt, hadoop-8218.txt
>
>
> HADOOP-8202 changed the behavior of RPC.stopProxy() to throw an exception if called on
an object which doesn't implement Closeable. Unfortunately, we use mock objects in many test
cases, and those mocks don't implement Closeable. This is causing TestZKFailoverController
to fail in trunk, for example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message