hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8179) risk of NPE in CopyCommands processArguments()
Date Fri, 16 Mar 2012 16:45:39 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231366#comment-13231366
] 

Steve Loughran commented on HADOOP-8179:
----------------------------------------


Sorry, I should have given more detail.
yes, that's what it's complaining about, and yes, moving it up would be the other solution.


If done rigorously a test ought to go with the patch too, but it is a very small change...
                
> risk of NPE in CopyCommands processArguments()
> ----------------------------------------------
>
>                 Key: HADOOP-8179
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8179
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.24.0
>            Reporter: Steve Loughran
>            Priority: Minor
>
> My IDE is warning me that the {{is.close()}} method will NPE if the {{is = src.fs.open(src.path);}}
call raises an exception, which could happen if the source path could not be opened. There
should be an if (is!=null) wrapper

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message