hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8121) Active Directory Group Mapping Service
Date Wed, 07 Mar 2012 21:20:57 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224716#comment-13224716

Aaron T. Myers commented on HADOOP-8121:

Very close now, Natty. Just a few little comments.

# In the class comment, rather than "slaves to an LDAP server" how about "connects directly
to an LDAP server" ?
# Should use 4-space indentation on the class declaration line.
# No need to initialize SEARCH_CONTROLS in the static { } block. Just do it inline with the
# Don't pull out the config keys on every call to getGroups. Instead, just do it once in the
call to setConf and set some instance variables.
# Why have a synchronized block around all the content of getGroups, vs just making the whole
method synchronized?
# I don't understand the comment "getDirContext needs to be synchronized, since we're potentially
setting up a singleton"
# What's the point of assigning SEARCH_CONTROLS to a local variable in getGroups?
# I don't understand the comment "// If we didn't get the group, just return the groups we
know about"
# Some odd indentation in getDirContext, and should probably synchronize getDirContext as
# s/for/of/g in "The URL for the LDAP server to use"
# No need for the instance variable mappingService in the test.
# I don't understand where the "hdfs" user comes from in testGetGroups. Why isn't that mentioned
anywhere in setupMocks?
> Active Directory Group Mapping Service
> --------------------------------------
>                 Key: HADOOP-8121
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8121
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: security
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>         Attachments: HADOOP-8121.patch, HADOOP-8121.patch, HADOOP-8121.patch, HADOOP-8121.patch
> Planning on building a group mapping service that will go and talk directly to an Active
Directory setup to get group memberships

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message