hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8174) Remove confusing comment in Path#isAbsolute()
Date Fri, 16 Mar 2012 00:20:41 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230745#comment-13230745
] 

Eli Collins commented on HADOOP-8174:
-------------------------------------

@Suresh, looks good.  How about removing the comment "A path string is absolute if it begins
with a slash" at the top of the file so we just have one place that defines what absolute
means.

@Sanjay, unfortunately URI is not an implementation detail of Path, the Path constructor takes
a java.net.URI object, has a toUri method that returns one that is used extensively. The code
uses Paths and URIs interchangably so the URI semantics are leaked all over the Hadoop code
base.
                
> Remove confusing comment in Path#isAbsolute()
> ---------------------------------------------
>
>                 Key: HADOOP-8174
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8174
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 0.23.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-8174.txt
>
>
> The method is checking for absolute path correctly. When scheme and authority are present,
the path is absolute. So the following comment needs to be removed.
> {noformat}
>   /**
>    * There is some ambiguity here. An absolute path is a slash
>    * relative name without a scheme or an authority.
>    * So either this method was incorrectly named or its
>    * implementation is incorrect. This method returns true
>    * even if there is a scheme and authority.
>    */
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message