hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7900) LocalDirAllocator confChanged() accesses conf.get() twice
Date Sun, 11 Mar 2012 19:38:39 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227219#comment-13227219
] 

Hudson commented on HADOOP-7900:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #1865 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1865/])
    HADOOP-7900. LocalDirAllocator confChanged() accesses conf.get() twice. Contributed by
Ravi Gummadi. (Revision 1299434)

     Result = SUCCESS
umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1299434
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java

                
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
>                 Key: HADOOP-7900
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7900
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.24.0, 0.23.1
>            Reporter: Ravi Gummadi
>            Assignee: Ravi Gummadi
>             Fix For: 0.23.3
>
>         Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily.
The 2 calls can give 2 different values, which can lead to issues because the first call's
return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged()
method --- So the comparison is wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message