[ https://issues.apache.org/jira/browse/HADOOP-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225811#comment-13225811
]
Hadoop QA commented on HADOOP-8154:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517597/hadoop-8154.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit
warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/691//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/691//console
This message is automatically generated.
> DNS#getIPs shouldn't silently return the local host IP for bogus interface names
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8154
> URL: https://issues.apache.org/jira/browse/HADOOP-8154
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-8154.txt
>
>
> DNS#getIPs silently returns the local host IP for bogus interface names. In this case
let's throw an UnknownHostException. This is technically an incompatbile change. I suspect
the current behavior was origininally introduced so the interface name "default" works w/o
explicitly checking for it. It may also be used in cases where someone is using a shared config
file and an option like "dfs.datanode.dns.interface" or "hbase.master.dns.interface" and eg
interface "eth3" that some hosts don't have, though I think silently ignorning this is the
wrong behavior (those hosts should be configured to use a different interface).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
|