hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8202) stopproxy() is not closing the proxies correctly
Date Fri, 23 Mar 2012 19:53:28 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236996#comment-13236996
] 

Aaron T. Myers commented on HADOOP-8202:
----------------------------------------

bq. Not necessary - all invocation handlers in Hadoop are RpcInvocationHandlers and they implement
Closeable.

Can you guarantee that all future invocation handlers in Hadoop will implement Closeable?

bq. I think this seems wholly unnecessary. Currently stopProxy is completely failing. I know
that multiple times things have changed in this part of the code, and has been broken for
some time.

This is a great reason to add a test - so that such things don't regress in the future.

bq. This is your coding style. I am not sure if it should be followed by every one.

Sure, it's a preference, but that in itself isn't a good reason to not address the comment.
Can you comment on why it's better to split the reasons for an error across several log statements?

bq. I want to look at the ProtocolTranslator and why it is needed in detail. In this part
of the code clearly ProtocolTranslator is not required.

If you have a better way to implement RPC.getServerAddress, I'm happy to hear it.

bq. The test was TestBackupNode.

Thanks for the info, Hari.
                
> stopproxy() is not closing the proxies correctly
> ------------------------------------------------
>
>                 Key: HADOOP-8202
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8202
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Hari Mankude
>            Assignee: Hari Mankude
>            Priority: Minor
>         Attachments: HADOOP-8202.patch, HADOOP-8202.patch
>
>
> I was running testbackupnode and noticed that NNprotocol proxy was not being closed.
Talked with Suresh and he observed that most of the protocols do not implement ProtocolTranslator
and hence the logic in stopproxy() does not work. Instead, since all of them are closeable,
Suresh suggested that closeable property should be used at close.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message