hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8131) FsShell put doesn't correctly handle a non-existent dir
Date Fri, 02 Mar 2012 15:33:57 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220995#comment-13220995
] 

Robert Joseph Evans commented on HADOOP-8131:
---------------------------------------------

>From a quick look at the code it mostly looks good.  I don't like the name.equals in the
checking for a parent, but like the comment says there really is no other way I can think
of to know if it is a directory or not, especially a directory that does not exist.

I also noticed some commented out code in the tests, and some calls to system.out.  Please
remove the commented out code, and verify that call of the calls to System.out are what you
want.  It might be better to change them to be log statements.

I will look at the logic more closely now.
                
> FsShell put doesn't correctly handle a non-existent dir
> -------------------------------------------------------
>
>                 Key: HADOOP-8131
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8131
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>            Priority: Critical
>         Attachments: HADOOP-8131.patch, HADOOP-8131.patch
>
>
> {noformat}
> $ hadoop fs -ls
> ls: `.': No such file or directory
> $ hadoop fs -put file
> $ hadoop fs -ls
> Found 1 items
> -rw-r--r--   1 kihwal supergroup       2076 2011-11-04 10:37 .._COPYING_
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message