hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8121) Active Directory Group Mapping Service
Date Thu, 08 Mar 2012 20:49:57 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225484#comment-13225484
] 

Aaron T. Myers commented on HADOOP-8121:
----------------------------------------

I see what you're saying re: the arbitrary user name, but in the latest patch it still looks
to me like you're using "hdfs" in the test case. Obviously this will work, but I think you
should either change the name so it's obvious that it's arbitrary, or add a comment explaining
this.

I'd also recommend you move the comment "The underlying LdapCtx is also not thread-safe..."
to the be in the method comment.

+1 once these two issues are addressed.
                
> Active Directory Group Mapping Service
> --------------------------------------
>
>                 Key: HADOOP-8121
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8121
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: security
>            Reporter: Jonathan Natkins
>            Assignee: Jonathan Natkins
>         Attachments: HADOOP-8121.patch, HADOOP-8121.patch, HADOOP-8121.patch, HADOOP-8121.patch,
HADOOP-8121.patch, HADOOP-8121.patch
>
>
> Planning on building a group mapping service that will go and talk directly to an Active
Directory setup to get group memberships

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message