hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8135) Add ByteBufferReadable interface to FSDataInputStream
Date Fri, 02 Mar 2012 22:46:54 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221327#comment-13221327
] 

Aaron T. Myers commented on HADOOP-8135:
----------------------------------------

Patch looks pretty good to me, Henry. Just a few little nits. +1 once these are addressed:

# Please add a javadoc explaining the "buf" param and the IOException for ByteBufferReadable#read.
# Please remove the unrelated changes adding @Override annotations to the other methods of
FSDataInputStream.

Even though this patch introduces an interface which as yet has no actual implementation,
I'd like to commit it to trunk anyway so that test-patch can be used during reviews on HDFS-2834.
If it turns out that HDFS-2834 doesn't get committed in a timely fashion, then I'll revert
this patch.

Any objections to this plan? If not, I'll commit this in a few hours.
                
> Add ByteBufferReadable interface to FSDataInputStream
> -----------------------------------------------------
>
>                 Key: HADOOP-8135
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8135
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: fs
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>         Attachments: HADOOP-8135.patch
>
>
> To prepare for HDFS-2834, it's useful to add an interface to FSDataInputStream (and others
inside hdfs) that adds a read(ByteBuffer...) method as follows:
> {code}
>   /**
>    * Reads up to buf.remaining() bytes into buf. Callers should use
>    * buf.limit(..) to control the size of the desired read.
>    * 
>    * After the call, buf.position() should be unchanged, and therefore any data
>    * can be immediately read from buf.
>    * 
>    * @param buf
>    * @return - the number of bytes available to read from buf
>    * @throws IOException
>    */
>   public int read(ByteBuffer buf) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message