hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ravi Prakash (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7985) maven build should be super fast when there are no changes
Date Wed, 21 Mar 2012 18:01:41 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234605#comment-13234605
] 

Ravi Prakash commented on HADOOP-7985:
--------------------------------------

all protobuf compilation sections in pom.xml can be modified like this
{noformat}
$ git diff pom.xml 
diff --git a/hadoop-hdfs-project/hadoop-hdfs/pom.xml b/hadoop-hdfs-project/hadoop-hdfs/pom.xml
index 0dcff87..7384385 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/pom.xml
+++ b/hadoop-hdfs-project/hadoop-hdfs/pom.xml
@@ -238,9 +238,9 @@
                     mkdir -p $JAVA_DIR 2> /dev/null
                     for PROTO_FILE in `ls $PROTO_DIR/*.proto 2> /dev/null`
                     do
-                        if [ "$IS_WIN" = "true" ]; then
+                        if [[ "$IS_WIN" = "true" &amp;&amp; $PROTO_FILE -nt $WIN_JAVA_DIR
]]; then
                           protoc -I$WIN_PROTO_DIR --java_out=$WIN_JAVA_DIR $PROTO_FILE
-                        else
+                        elif [ $PROTO_FILE -nt $JAVA_DIR ]; then
                           protoc -I$PROTO_DIR --java_out=$JAVA_DIR $PROTO_FILE
                         fi
                     done
{noformat}
I am now trying to optimize mvn -P-cbuild -Dmaven.javadoc.skip -DskipTests -X compile

Even here jsps are being compiled into java files every time unnecessarily
                
> maven build should be super fast when there are no changes
> ----------------------------------------------------------
>
>                 Key: HADOOP-7985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7985
>             Project: Hadoop Common
>          Issue Type: Wish
>          Components: build
>    Affects Versions: 0.23.0
>            Reporter: Ravi Prakash
>              Labels: build, maven
>
> I use this command "mvn -Pdist -P-cbuild -Dmaven.javadoc.skip -DskipTests install" to
build. Without ANY changes in code, running this command takes 1:32. It seems to me this is
too long. Investigate if this time can be reduced drastically.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message