hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8174) Remove confusing comment in Path#isAbsolute()
Date Thu, 15 Mar 2012 20:22:37 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230507#comment-13230507

Suresh Srinivas commented on HADOOP-8174:

isAbsolute() is a method on Path and so the method should not be attributed to URI, even if
Path wraps URI, which is implementation detail.

Now I get what the problem is, there is a comment:
/** True if the path component of this URI is absolute. */

Hence the comment following it. I will fix the comment.
> Remove confusing comment in Path#isAbsolute()
> ---------------------------------------------
>                 Key: HADOOP-8174
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8174
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 0.23.0
>            Reporter: Suresh Srinivas
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>         Attachments: HADOOP-8174.txt
> The method is checking for absolute path correctly. When scheme and authority are present,
the path is absolute. So the following comment needs to be removed.
> {noformat}
>   /**
>    * There is some ambiguity here. An absolute path is a slash
>    * relative name without a scheme or an authority.
>    * So either this method was incorrectly named or its
>    * implementation is incorrect. This method returns true
>    * even if there is a scheme and authority.
>    */
> {noformat}

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message