hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hari Mankude (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8202) stopproxy() is not closing the proxies correctly
Date Mon, 26 Mar 2012 05:24:43 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238109#comment-13238109
] 

Hari Mankude commented on HADOOP-8202:
--------------------------------------

bq.
Can you list here which tests failed? Can you comment on Todd's comment that he's surprised
many HDFS tests didn't fail? Perhaps it's because in most tests where we mock out a protocol
object, we never try to close that protocol object. Just a guess.

Sure, the tests that failed were 
1. TestStartup
2. TestValidateConfigurationSettings
3. TestGetBlocks

I have a trivial fix for TestGetBlocks, even though unrelated to this jira. Other tests definitely
don't seem to be doing stopproxy(). So, will file the jiras for now.

Regarding Todd's comment, my guess is also that we never try to close mockito based proxy
objects. 
                
> stopproxy() is not closing the proxies correctly
> ------------------------------------------------
>
>                 Key: HADOOP-8202
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8202
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Hari Mankude
>            Assignee: Hari Mankude
>            Priority: Minor
>         Attachments: HADOOP-8202-1.patch, HADOOP-8202-2.patch, HADOOP-8202-3.patch, HADOOP-8202.patch,
HADOOP-8202.patch
>
>
> I was running testbackupnode and noticed that NNprotocol proxy was not being closed.
Talked with Suresh and he observed that most of the protocols do not implement ProtocolTranslator
and hence the logic in stopproxy() does not work. Instead, since all of them are closeable,
Suresh suggested that closeable property should be used at close.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message