hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8088) User-group mapping cache incorrectly does negative caching on transient failures
Date Sun, 18 Mar 2012 03:38:06 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232141#comment-13232141

Hadoop QA commented on HADOOP-8088:

+1 overall.  Here are the results of testing the latest attachment 
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/724//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/724//console

This message is automatically generated.
> User-group mapping cache incorrectly does negative caching on transient failures
> --------------------------------------------------------------------------------
>                 Key: HADOOP-8088
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8088
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions:, 0.24.0, 0.23.1, 1.0.0, 1.1.0
>            Reporter: Kihwal Lee
>             Fix For: 0.24.0, 1.1.0, 0.23.2
>         Attachments: hadoop-8088-branch-1.patch, hadoop-8088-branch-1.patch, hadoop-8088-trunk.patch,
hadoop-8088-trunk.patch, hadoop-8088-trunk.patch
> We've seen a case where some getGroups() calls fail when the ldap server or the network
is having transient failures. Looking at the code, the shell-based and the JNI-based implementations
swallow exceptions and return an empty or partial list. The caller, Groups#getGroups() adds
this likely empty list into the mapping cache for the user. This will function as negative
caching until the cache expires. I don't think we want negative caching here, but even if
we do, it should be intelligent enough to distinguish transient failures from ENOENT. The
log message in the jni-based impl also needs an improvement. It should print what exception
it encountered instead of just saying one happened.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message