hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-8218) RPC.closeProxy shouldn't throw error when closing a mock
Date Tue, 27 Mar 2012 04:57:31 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Todd Lipcon updated HADOOP-8218:
--------------------------------

    Attachment: hadoop-8218.txt

This much bigger patch implements option #3 as Tom suggested.
It will also require a HDFS-side change to fix TestDFSHAAdmin which is currently failing.

So, I still think #2 is better, but you both think #3 is better, we'll go ahead with this,
and I'll file a new HDFS JIRA to fix TestDFSHAAdmin to use the new mock util once this is
committed.
                
> RPC.closeProxy shouldn't throw error when closing a mock
> --------------------------------------------------------
>
>                 Key: HADOOP-8218
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8218
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc, test
>    Affects Versions: 0.24.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hadoop-8218.txt, hadoop-8218.txt
>
>
> HADOOP-8202 changed the behavior of RPC.stopProxy() to throw an exception if called on
an object which doesn't implement Closeable. Unfortunately, we use mock objects in many test
cases, and those mocks don't implement Closeable. This is causing TestZKFailoverController
to fail in trunk, for example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message