hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8135) Add ByteBufferReadable interface to FSDataInputStream
Date Fri, 02 Mar 2012 22:37:58 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221317#comment-13221317
] 

Hadoop QA commented on HADOOP-8135:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12516892/HADOOP-8135.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/664//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/664//console

This message is automatically generated.
                
> Add ByteBufferReadable interface to FSDataInputStream
> -----------------------------------------------------
>
>                 Key: HADOOP-8135
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8135
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: fs
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>         Attachments: HADOOP-8135.patch
>
>
> To prepare for HDFS-2834, it's useful to add an interface to FSDataInputStream (and others
inside hdfs) that adds a read(ByteBuffer...) method as follows:
> {code}
>   /**
>    * Reads up to buf.remaining() bytes into buf. Callers should use
>    * buf.limit(..) to control the size of the desired read.
>    * 
>    * After the call, buf.position() should be unchanged, and therefore any data
>    * can be immediately read from buf.
>    * 
>    * @param buf
>    * @return - the number of bytes available to read from buf
>    * @throws IOException
>    */
>   public int read(ByteBuffer buf) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message