Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2CFBA9868 for ; Tue, 28 Feb 2012 19:32:10 +0000 (UTC) Received: (qmail 22640 invoked by uid 500); 28 Feb 2012 19:32:10 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 22574 invoked by uid 500); 28 Feb 2012 19:32:09 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 22565 invoked by uid 99); 28 Feb 2012 19:32:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Feb 2012 19:32:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Feb 2012 19:32:07 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 4FB8233E9C3 for ; Tue, 28 Feb 2012 19:31:46 +0000 (UTC) Date: Tue, 28 Feb 2012 19:31:46 +0000 (UTC) From: "Hadoop QA (Commented) (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <834113086.29832.1330457506327.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <919127566.44113.1324738230891.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-7940) method clear() in org.apache.hadoop.io.Text does not work MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-7940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218519#comment-13218519 ] Hadoop QA commented on HADOOP-7940: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12516354/HADOOP-7940.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.fs.viewfs.TestViewFsTrash +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/638//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/638//console This message is automatically generated. > method clear() in org.apache.hadoop.io.Text does not work > --------------------------------------------------------- > > Key: HADOOP-7940 > URL: https://issues.apache.org/jira/browse/HADOOP-7940 > Project: Hadoop Common > Issue Type: Bug > Components: io > Affects Versions: 0.20.205.0 > Environment: Ubuntu, hadoop cloudera CDH3U2, Oracle SUN JDK 6U30 > Reporter: Aaron, > Assignee: Csaba Miklos > Labels: patch > Attachments: HADOOP-7940.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > LineReader reader = new LineReader(in, 4096); > ... > Text text = new Text(); > while((reader.readLine(text)) > 0) { > ... > text.clear(); > } > } > Even the clear() method is called each time, some bytes are still not filled as zero. > So, when reader.readLine(text) is called in a loop, some bytes are dirty which was from last call. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira