Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E24E6924F for ; Tue, 28 Feb 2012 10:48:13 +0000 (UTC) Received: (qmail 13419 invoked by uid 500); 28 Feb 2012 10:48:13 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 13307 invoked by uid 500); 28 Feb 2012 10:48:12 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 13145 invoked by uid 99); 28 Feb 2012 10:48:12 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Feb 2012 10:48:12 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Feb 2012 10:48:10 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 4C7AA33E3C9 for ; Tue, 28 Feb 2012 10:47:49 +0000 (UTC) Date: Tue, 28 Feb 2012 10:47:49 +0000 (UTC) From: "Ahmed Radwan (Commented) (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1766022377.27490.1330426069314.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-6871) When the value of a configuration key is set to its unresolved form, it causes the IllegalStateException in Configuration.get() stating that substitution depth is too large. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-6871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218063#comment-13218063 ] Ahmed Radwan commented on HADOOP-6871: -------------------------------------- +1, the patch looks good. The included test case confirms the right behavior of detecting cycles and returning the current value. > When the value of a configuration key is set to its unresolved form, it causes the IllegalStateException in Configuration.get() stating that substitution depth is too large. > ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: HADOOP-6871 > URL: https://issues.apache.org/jira/browse/HADOOP-6871 > Project: Hadoop Common > Issue Type: Bug > Components: conf > Reporter: Arvind Prabhakar > Attachments: HADOOP-6871-1.patch, HADOOP-6871-2.patch, HADOOP-6871-3.patch, HADOOP-6871.patch > > > When a configuration value is set to its unresolved expression string, it leads to recursive substitution attempts in {{Configuration.substituteVars(String)}} method until the max substitution check kicks in and raises an IllegalStateException indicating that the substitution depth is too large. For example, the configuration key "{{foobar}}" with a value set to "{{$\{foobar\}}}" will cause this behavior. > While this is not a usual use case, it can happen in build environments where a property value is not specified and yet being passed into the test mechanism leading to failures due to this limitation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira