Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Tue, 28 Feb 2012 00:53:49 +0000 (UTC)
From: "Aaron T. Myers (Commented) (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <1437288934.25812.1330390429322.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <450161571.25132.1330381190262.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-8116) HA: RetriableCommand is using
 RetryPolicy incorrectly after HADOOP-7896
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217761#comment-13217761 ] 

Aaron T. Myers commented on HADOOP-8116:
----------------------------------------

Oh, I should've mentioned - the two test cases which will fail without this patch are TestCopyMapper and TestRetriableCommand.
                
> HA: RetriableCommand is using RetryPolicy incorrectly after HADOOP-7896
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-8116
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8116
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: util
>    Affects Versions: HA Branch (HDFS-1623)
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>         Attachments: HADOOP-8116-HDFS-1623.patch
>
>
> HADOOP-7896 (on the HA branch) refactored RetryAction from an enum to a class, and also moved the act of sleeping to delay retries from the RetryPolicy implementations into RetryInvocationHandler. RetriableCommand, in the rewritten distcp tool, uses RetryPolicy and associated classes from o.a.h.io.retry. When MAPREDUCE-2765 was merged into the HA branch, RetriableCommand wasn't adjusted accordingly to make use of the new structure of the o.a.h.io.retry classes.
> It's probably generally not kosher for RetriableCommand to be using the RetryPolicy classes at all, since they're not really intended to be used except by RetryInvocationHandler. But, regardless, this JIRA aims to make distcp's use of the o.a.h.io.retry classes functional again.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira