hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7814) Add ability to add the contents of a properties file to Configuration
Date Sat, 18 Feb 2012 20:55:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211075#comment-13211075
] 

Steve Loughran commented on HADOOP-7814:
----------------------------------------

basic idea looks good, and I can see some uses, 
 # I propose adding put this into the 0.23.x branch/trunk rather than the stable 1.x branch
 # An export to properties could be good too for the full round tripping (and some useful
diagnostics on bug reports)

Though there are some coding style and practises to review before a patch could be applied:

{{Configuration}}
* major re-ordering of imports
* spacing doesn't follow style rutes
* exception logging events should always include the exception as the second
  argument so that the stack trace is preserved
* the {{in.close()}} handler in the {{finally}} clause should just log at info and not at
fatal


{{TestConfiguration}}

* there's an import * import static org.junit.Assert.*;
* re-ordering of imports
* some gratutious indentation

                
> Add ability to add the contents of a properties file to Configuration
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-7814
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7814
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Kristofer Tomasette
>            Priority: Minor
>         Attachments: HADOOP-7814.patch, HADOOP-7814.patch, HADOOP-7814.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Add a method  to Configuration that will take a location on the local filesystem of a
properties file.  Method should read in the file's properties and add them to the Configuration
object.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message