hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8069) Enable TCP_NODELAY by default for IPC
Date Tue, 14 Feb 2012 06:14:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207539#comment-13207539
] 

Hadoop QA commented on HADOOP-8069:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12514452/hadoop-8069.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/594//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/594//console

This message is automatically generated.
                
> Enable TCP_NODELAY by default for IPC
> -------------------------------------
>
>                 Key: HADOOP-8069
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8069
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-8069.txt
>
>
> I think we should switch the default for the IPC client and server NODELAY options to
true. As wikipedia says:
> {quote}
> In general, since Nagle's algorithm is only a defense against careless applications,
it will not benefit a carefully written application that takes proper care of buffering; the
algorithm has either no effect, or negative effect on the application.
> {quote}
> Since our IPC layer is well contained and does its own buffering, we shouldn't be careless.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message