hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8116) HA: RetriableCommand is using RetryPolicy incorrectly after HADOOP-7896
Date Tue, 28 Feb 2012 16:43:46 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218342#comment-13218342
] 

Eli Collins commented on HADOOP-8116:
-------------------------------------

+1  looks great

Nit, the line where you pull out the nested exception in TestCopyMapper could use a comment
indicating why this is necessary

Also wrt your comment that it's not kosher for RetriableCommand to be using the RetryPolicy
classes, file a MR jira for that?
                
> HA: RetriableCommand is using RetryPolicy incorrectly after HADOOP-7896
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-8116
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8116
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: util
>    Affects Versions: HA Branch (HDFS-1623)
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>         Attachments: HADOOP-8116-HDFS-1623.patch
>
>
> HADOOP-7896 (on the HA branch) refactored RetryAction from an enum to a class, and also
moved the act of sleeping to delay retries from the RetryPolicy implementations into RetryInvocationHandler.
RetriableCommand, in the rewritten distcp tool, uses RetryPolicy and associated classes from
o.a.h.io.retry. When MAPREDUCE-2765 was merged into the HA branch, RetriableCommand wasn't
adjusted accordingly to make use of the new structure of the o.a.h.io.retry classes.
> It's probably generally not kosher for RetriableCommand to be using the RetryPolicy classes
at all, since they're not really intended to be used except by RetryInvocationHandler. But,
regardless, this JIRA aims to make distcp's use of the o.a.h.io.retry classes functional again.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message