hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7350) Use ServiceLoader to discover compression codec classes
Date Tue, 14 Feb 2012 06:06:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207536#comment-13207536

Alejandro Abdelnur commented on HADOOP-7350:

I may have expressed incorrectly, my suggestion was that in the getCodecClasses(Configuration)
method, the loop loading the codecs from CODEC_PROVIDERS should be done before loading the
codecs from the Hadoop 'io.compression.codec' property. Also, in the CompressionCodecFactory()
constructor, doing a reverse of the list seems wrong as that would effectively put the service
loaded ones first. I think that the reverse should not be there, then the list of codecs is
ALL_SERVICE_CODECS (in non-deterministic order) and then the configuration set ones, in order
or appearance where the last one overrides.
> Use ServiceLoader to discover compression codec classes
> -------------------------------------------------------
>                 Key: HADOOP-7350
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7350
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, io
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: HADOOP-7350.patch, HADOOP-7350.patch, HADOOP-7350.patch, HADOOP-7350.patch,
HADOOP-7350.patch, HADOOP-7350.patch, HADOOP-7350.patch
> By using a ServiceLoader users wouldn't have to add codec classes to io.compression.codecs
for codecs that aren't shipped with Hadoop (e.g. LZO), since they would be automatically picked
up from the classpath.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message