hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Graves (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8048) Allow merging of Credentials
Date Thu, 09 Feb 2012 18:36:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204718#comment-13204718

Thomas Graves commented on HADOOP-8048:

Sorry to clarify the first comment - in the tests for addAll and mergeAll.  I think it would
be useful to add another token and service that won't have a corresponding one in the credsToAdd,
and then assert after doing the addAll/mergeAll that that token and service still exist and
haven't changed.
> Allow merging of Credentials
> ----------------------------
>                 Key: HADOOP-8048
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8048
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.24.0, 0.23.1
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8048.patch
> There is an existing {{Credentials#addAll}} which combines two {{Credentials}}, but it
overwrites all existing {{Credentials}}.  There should be a {{Credentials#mergeAll}} that
will not overwrite.  This will facility the cleanup of code in {{TokenCache}} denoted with:
> {code}
> //TODO: Need to come up with a better place to put
> //this block of code to do with reading the file
> {code}
> The token cache basically needs to merge the contents of a binary credentials file when
it fails to find a token.  Performing the merge within {{Credentials}} is cleaner, and will
break the cross-component dependency whereby the {{TokenCache}} currently has to have intimate
knowledge of how the {{FileSystem}} will key tokens in the cache.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message