hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Graves (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8020) test-patch will +1 patches with added javadoc warnings
Date Fri, 03 Feb 2012 23:15:54 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200146#comment-13200146
] 

Thomas Graves commented on HADOOP-8020:
---------------------------------------

it looks like the extra javadoc warnings in trunk are:

[WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/FastByteComparisons.java:25:
warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
                                                                                         
                                             >  [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/FastByteComparisons.java:117:
warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release


That file was added under HADOOP-7761.  It seems like that would be good to pull into branch
23, so perhaps this patch isn't needed if the plan is to merge HADOOP-7761.
                
> test-patch will +1 patches with added javadoc warnings
> ------------------------------------------------------
>
>                 Key: HADOOP-8020
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8020
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.1
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>         Attachments: HADOOP-8020.patch, patchJavadocWarnings.txt.hadoop-trunk
>
>
> OK_JAVADOC_WARNINGS is set too high in hadoop-common-project/dev-support/test-patch.properties
> {noformat}
> $ cd hadoop-common-project/
> $ mvn clean test javadoc:javadoc -DskipTests -Pdocs -DHadoopPatchProcess > ~/patchJavadocWarnings.txt.hadoop-trunk
2>&1
> $ grep '\[WARNING\]' ~/patchJavadocWarnings.txt.hadoop-trunk | awk '/Javadoc Warnings/,EOF'
| grep warning | awk 'BEGIN {total = 0} {total += 1} END {print total}'
> 11
> {noformat}
> {noformat}
> $ cat dev-support/test-patch.properties
> OK_RELEASEAUDIT_WARNINGS=0
> OK_FINDBUGS_WARNINGS=0
> OK_JAVADOC_WARNINGS=13
> {noformat}
> This will allow in 2 new javadoc warnings and still +1 the build

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message