hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7972) HAServiceProtocol exceptions need to be unwrapped before it can be used
Date Mon, 16 Jan 2012 21:29:38 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187201#comment-13187201
] 

Aaron T. Myers commented on HADOOP-7972:
----------------------------------------

bq. We should have used DFSClient in FailoverController when accessing HAServiceProtocol.

Not sure I agree with that. DFSClient currently only accesses ClientProtocol methods, and
it seems a bit odd to lump in the HA administrative API into DFSClient.

bq. I am not sure I agree that unwrapping in a Helper is such an ugly choice.

I don't think it's necessarily ugly, just not as beautiful as it could be. :)

Such a class as I described it could also be used for HAServiceProtocol instantiation, which
is currently duplicated in both HAAdmin and MiniDFSCluster.

bq. Any way, this could be moved over to translators when we move over HAServiceProtocol to
protobuf.

Sure, that's a fine solution.
                
> HAServiceProtocol exceptions need to be unwrapped before it can be used
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-7972
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7972
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ha
>    Affects Versions: HA Branch (HDFS-1623)
>            Reporter: Hari Mankude
>            Assignee: Hari Mankude
>         Attachments: HADOOP-7972.txt, HADOOP-7972.txt
>
>
> Remote exceptions for all the interfaces in HAServiceProtocol class has to be unwrapped
before it can be used. All the HAServiceProtocol interfaces throw exceptions of type RemoteException
by default.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message