hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daryn Sharp (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7973) DistributedFileSystem close has severe consequences
Date Fri, 13 Jan 2012 22:58:41 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185953#comment-13185953
] 

Daryn Sharp commented on HADOOP-7973:
-------------------------------------

We'll experiment on a performance grid and see what happens with the cache off.  I'm concerned
about whether GC will keep up with all the leaked {{FileSystem}} and {{DFSClient}} objects.

Just food for thought:  It seems that {{FileSystem#close}} should be smart enough to only
close the fs if it's not in the cache (can check via the {{key}} field), but be a no-op if
it's in the cache.  A static {{FileSystem}} method for unconditionally closing a cached {{FileSystem}}
could provide symmetry to the {{get}} method which populates the cache.
                
> DistributedFileSystem close has severe consequences
> ---------------------------------------------------
>
>                 Key: HADOOP-7973
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7973
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 1.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>            Priority: Blocker
>         Attachments: HADOOP-7973.patch
>
>
> The way {{FileSystem#close}} works is very problematic.  Since the {{FileSystems}} are
cached, any {{close}} by any caller will cause problems for every other reference to it. 
Will add more detail in the comments.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message