hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7956) Remove duplicate definition of default config values
Date Wed, 04 Jan 2012 21:19:40 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179882#comment-13179882
] 

Robert Joseph Evans commented on HADOOP-7956:
---------------------------------------------

Suresh, deleting the version in the code could cause backwards compatibility issues.  CommonConfigurationKeysPublic.java
is public not only in the java since but also @InterfaceAudience.Public.
                
> Remove duplicate definition of default config values
> ----------------------------------------------------
>
>                 Key: HADOOP-7956
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7956
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Eli Collins
>
> We define default configuration values in two places:
> #1 The default.xml files (eg core-default.xml)
> #2 The _DEFAULT defines in *Keys.java
> This means the defaults used in the code may or may not be dead code based on whether
the config is present in the default xml file. Would be good to define these in one place.
Eg:
> #1 Just have the defines in the code and figure out how to make those accessible as a
loadable resource (eg could generate the default files from the defines in the KeysPublic*
files)
> #2 Remove one of the definitions entirely (possible to live w/o the default files?) or
> #3 Remove the overlap between the code and default files

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message