Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4CE607979 for ; Fri, 9 Dec 2011 17:10:01 +0000 (UTC) Received: (qmail 18857 invoked by uid 500); 9 Dec 2011 17:10:01 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 18832 invoked by uid 500); 9 Dec 2011 17:10:01 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 18822 invoked by uid 99); 9 Dec 2011 17:10:01 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Dec 2011 17:10:01 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Dec 2011 17:10:00 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 04A4810A6F0 for ; Fri, 9 Dec 2011 17:09:40 +0000 (UTC) Date: Fri, 9 Dec 2011 17:09:40 +0000 (UTC) From: "Ravi Gummadi (Updated) (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <587433605.58942.1323450580020.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1657339732.58927.1323450219966.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HADOOP-7900) LocalDirAllocator confChanged() accesses conf.get() twice MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Gummadi updated HADOOP-7900: --------------------------------- Component/s: fs Description: LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong. Environment: (was: mr) > LocalDirAllocator confChanged() accesses conf.get() twice > --------------------------------------------------------- > > Key: HADOOP-7900 > URL: https://issues.apache.org/jira/browse/HADOOP-7900 > Project: Hadoop Common > Issue Type: Bug > Components: fs > Affects Versions: 0.24.0, 0.23.1 > Reporter: Ravi Gummadi > Fix For: 0.23.1 > > > LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira