Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Tue, 13 Dec 2011 15:41:31 +0000 (UTC)
From: "Hudson (Commented) (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <1928245674.6012.1323790891453.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1850228738.35075.1322838459984.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-7878) Regression HADOOP-7777 switch
 changes break HDFS tests when the isSingleSwitch() predicate is used
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168441#comment-13168441 ] 

Hudson commented on HADOOP-7878:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #926 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/926/])
    HADOOP-7878  Regression: HADOOP-7777 switch changes break HDFS tests when the isSingleSwitch() predicate is used

stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213263
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java

                
> Regression HADOOP-7777 switch changes break HDFS tests when the isSingleSwitch() predicate is used
> --------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7878
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7878
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>              Labels: regression
>             Fix For: 0.24.0, 0.23.1
>
>         Attachments: HADOOP-7878.patch, HADOOP-7878.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> This doesn't show up until you apply the HDFS-2492 patch, but the attempt to make the {{StaticMapping}} topology clever by deciding if it is single rack or multi rack based on its rack->node mapping breaks the HDFS {{TestBlocksWithNotEnoughRacks}} test. Why? Because the racks go in after the switch topology is cached by the {{BlockManager}}, which assumes the system is always single-switch.
> Fix: default to assuming multi-switch; remove the intelligence, add a setter for anyone who really wants to simulate single-switch racks. 
> Test: verify that a newly created simple mapping is multi switch

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira