Return-Path: 
 <common-issues-return-24408-apmail-hadoop-common-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 27E9F771D
	for <apmail-hadoop-common-issues-archive@minotaur.apache.org>;
 Tue, 27 Dec 2011 07:06:56 +0000 (UTC)
Received: (qmail 56998 invoked by uid 500); 27 Dec 2011 07:06:55 -0000
Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org
Received: (qmail 56954 invoked by uid 500); 27 Dec 2011 07:06:55 -0000
Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:common-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:common-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:common-issues@hadoop.apache.org>
List-Id: <common-issues.hadoop.apache.org>
Reply-To: common-issues@hadoop.apache.org
Delivered-To: mailing list common-issues@hadoop.apache.org
Received: (qmail 56946 invoked by uid 99); 27 Dec 2011 07:06:54 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Dec 2011 07:06:54 +0000
X-ASF-Spam-Status: No, hits=-2001.3 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Dec 2011 07:06:52 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id DB7AA12A4E4
	for <common-issues@hadoop.apache.org>; Tue, 27 Dec 2011 07:06:30 +0000 (UTC)
Date: Tue, 27 Dec 2011 07:06:30 +0000 (UTC)
From: "Harsh J (Commented) (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <1732401811.46050.1324969590900.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1361338429.62211.1323562360074.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-7910) add configuration methods to
 handle human readable size values
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176104#comment-13176104 ] 

Harsh J commented on HADOOP-7910:
---------------------------------

Thanks Sho. The patch looks good. I'll commit it once the following couple of nits are addressed:

- {{fail("");}} messages such as {{"Too large number"}} is not very descriptive. These calls will fail the test with the string as the reason, so something like "Test passed for a number too large" or "Test passed for a number too small" are more easier to understand when such a thing happens. Makes sense? (You have the other fail() message correctly written, so just these last two that relate to Longs).
- The {{IllegalArgumentException}} that carries the message {{"binary prefix is allowed only k, m, g, t, p, e(case insensitive)"}} can be improved. Perhaps something more like: {{"Invalid size prefix %char in given string %string. Allowed prefixes are <set>"}}. Know that exception messages and log messages cater to users, and if we can be very clear at what's being given to them, it makes their life easier in hunting down the trouble and fixing it up themselves :)
- Javadoc for the getLongBytes method can carry a 'case insensitive' comment, for the devs.
                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira