Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 758419358 for ; Thu, 8 Dec 2011 07:36:05 +0000 (UTC) Received: (qmail 66501 invoked by uid 500); 8 Dec 2011 07:36:05 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 66409 invoked by uid 500); 8 Dec 2011 07:36:05 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 66401 invoked by uid 99); 8 Dec 2011 07:36:03 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2011 07:36:03 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2011 07:36:01 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id A1DA0106A32 for ; Thu, 8 Dec 2011 07:35:40 +0000 (UTC) Date: Thu, 8 Dec 2011 07:35:40 +0000 (UTC) From: "Sanjay Radia (Commented) (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1451187910.52746.1323329740664.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1070342622.52549.1323325300012.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-7897) ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165066#comment-13165066 ] Sanjay Radia commented on HADOOP-7897: -------------------------------------- {code} *
  • Exceptions encountered on the client side in this method are * thrown as is. {code} Change to {code} *
  • Exceptions encountered on the client side in this method are * wrapped in ServiceException as is. {code} +1 > ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine > ------------------------------------------------------------------------------------------ > > Key: HADOOP-7897 > URL: https://issues.apache.org/jira/browse/HADOOP-7897 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 0.24.0 > Reporter: Suresh Srinivas > Assignee: Suresh Srinivas > Fix For: 0.24.0 > > Attachments: HADOOP-7897.txt > > > In ProtobufRpcEngine the client side exceptions are wrapped in RpcClientException. The RpcClientException is used to create RemoteException which is set as cause in the thrown ServiceException. However WritableRpcEngine throws the client encountered exception as is. This difference in behavior causes, many tests to fail in the existing unit tests, which expect the client invoker() to thrown the exception as is. This jira makes the ProtobufRpcEngine behavior consistent with that of WritableRpcEngine. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira