hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amar Kamat (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7851) Configuration.getClasses() never returns the default value.
Date Thu, 08 Dec 2011 15:41:41 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165259#comment-13165259
] 

Amar Kamat commented on HADOOP-7851:
------------------------------------

Some comments on the first patch.
1. Instead of 
{code}
String[] classnames = StringUtils.getTrimmedStrings(valueString);
{code} 
use 
{code}
String[] classnames = getTrimmedStrings(name);
{code}

2. In the testcase, 
{code}
Class<?>[] classes = config
        .getClasses("testClassName", Configuration.class);
{code}
kindly use
{code}
Class<?>[] classes = 
    config.getClasses("testClassName", Configuration.class);
{code}

3. Instead of assertTrue, you can use assertEquals()
4. Kindly add a testcase for a value of "". The output should be an empty array.
                
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
>                 Key: HADOOP-7851
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7851
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Amar Kamat
>            Assignee: Uma Maheswara Rao G
>              Labels: configuration
>             Fix For: 0.24.0, 0.23.1
>
>         Attachments: HADOOP-7851.patch, HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message