hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7851) Configuration.getClasses() never returns the default value.
Date Thu, 08 Dec 2011 18:05:40 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165378#comment-13165378

Uma Maheswara Rao G commented on HADOOP-7851:

Thanks Amar for taking a look again.
Ok, it is better than get. its little lighter :-)

Updated the patch by addressing the comments.


kindly use

Class<?>[] classes = 
    config.getClasses("testClassName", Configuration.class);
This is due to formatter. I am usiing hadoop formatter only. Manually i changed it.

3. Instead of assertTrue, you can use assertEquals()
  Yes, assertEquals will give the values in trace when it is failing. But i included the value
in error message.Since they are premitives i used assertTrue. 
Now i changed it to assertEquals.  

4. Kindly add a testcase for a value of "". The output should be an empty array.
 Added test for "".

Amar, can you please take a look?


> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>                 Key: HADOOP-7851
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7851
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Amar Kamat
>            Assignee: Uma Maheswara Rao G
>              Labels: configuration
>             Fix For: 0.24.0, 0.23.1
>         Attachments: HADOOP-7851.patch, HADOOP-7851.patch, HADOOP-7851.patch
> Configuration.getClasses() never returns the default value.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message