hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7897) ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine
Date Thu, 08 Dec 2011 08:33:40 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165086#comment-13165086
] 

Hadoop QA commented on HADOOP-7897:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12506585/HADOOP-7897.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated 9 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/448//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/448//console

This message is automatically generated.
                
> ProtobufRPCEngine client side exception mechanism is not consistent with WritableRpcEngine
> ------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7897
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7897
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.24.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-7897.txt, HADOOP-7897.txt
>
>
> In ProtobufRpcEngine the client side exceptions are wrapped in RpcClientException. The
RpcClientException is used to create RemoteException which is set as cause in the thrown ServiceException.
However WritableRpcEngine throws the client encountered exception as is. This difference in
behavior causes, many tests to fail in the existing unit tests, which expect the client invoker()
to thrown the exception as is. This jira makes the ProtobufRpcEngine behavior consistent with
that of WritableRpcEngine.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message