hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7878) Regression HADOOP-7777 switch changes too clever for the StaticMapping
Date Sat, 10 Dec 2011 17:33:40 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166916#comment-13166916
] 

Hadoop QA commented on HADOOP-7878:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12506853/HADOOP-7878.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated 5 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/462//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/462//console

This message is automatically generated.
                
> Regression HADOOP-7777 switch changes too clever for the StaticMapping
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-7878
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7878
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>              Labels: regression
>         Attachments: HADOOP-7878.patch, HADOOP-7878.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> This doesn't show up until you apply the HDFS-2492 patch, but the attempt to make the
{{StaticMapping}} topology clever by deciding if it is single rack or multi rack based on
its rack->node mapping breaks the HDFS {{TestBlocksWithNotEnoughRacks}} test. Why? Because
the racks go in after the switch topology is cached by the {{BlockManager}}, which assumes
the system is always single-switch.
> Fix: default to assuming multi-switch; remove the intelligence, add a setter for anyone
who really wants to simulate single-switch racks. 
> Test: verify that a newly created simple mapping is multi switch

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message