hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7851) Configuration.getClasses() never returns the default value.
Date Thu, 08 Dec 2011 16:25:40 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165301#comment-13165301

Uma Maheswara Rao G commented on HADOOP-7851:

Hi Amar, Thanks for the review.

1. Instead of 

String[] classnames = StringUtils.getTrimmedStrings(valueString);

String[] classnames = getTrimmedStrings(name);

get call will be executed multiple times if i use getTrimmedStrings(name).
Because we should call get once for validating null and then call getTrimmedStrings. This
api again will call get and passed to StringUtils.getTrimmedStrings. That is the reason i
used directly StringUtils.getTrimmedStrings. do you agree with this?

i will update the patch with other comments. Can you please confirm above one.


> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>                 Key: HADOOP-7851
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7851
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Amar Kamat
>            Assignee: Uma Maheswara Rao G
>              Labels: configuration
>             Fix For: 0.24.0, 0.23.1
>         Attachments: HADOOP-7851.patch, HADOOP-7851.patch
> Configuration.getClasses() never returns the default value.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message