hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7879) DistributedFileSystem#createNonRecursive should also incrementWriteOps statistics.
Date Sat, 03 Dec 2011 01:35:40 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162002#comment-13162002
] 

Hadoop QA commented on HADOOP-7879:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12505953/hadoop-7870.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/428//console

This message is automatically generated.
                
> DistributedFileSystem#createNonRecursive should also incrementWriteOps statistics.
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-7879
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7879
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hadoop-7870.patch
>
>
> This method:
> {code}
>  public FSDataOutputStream createNonRecursive(Path f, FsPermission permission,
>       boolean overwrite,
>       int bufferSize, short replication, long blockSize, 
>       Progressable progress) throws IOException {
>     return new FSDataOutputStream
>         (dfs.create(getPathName(f), permission, 
>                     overwrite, false, replication, blockSize, progress, bufferSize),

>          statistics);
>   }
> {code}
> Needs a statistics.incrementWriteOps(1);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message