Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0DF9A72CC for ; Mon, 21 Nov 2011 06:47:14 +0000 (UTC) Received: (qmail 5368 invoked by uid 500); 21 Nov 2011 06:47:13 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 5328 invoked by uid 500); 21 Nov 2011 06:47:13 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 5320 invoked by uid 99); 21 Nov 2011 06:47:13 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Nov 2011 06:47:13 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Nov 2011 06:47:12 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id E994B92D1B for ; Mon, 21 Nov 2011 06:46:51 +0000 (UTC) Date: Mon, 21 Nov 2011 06:46:51 +0000 (UTC) From: "Hudson (Commented) (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <849359231.50408.1321858011958.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <760290213.40872.1321573311735.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-7833) Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154019#comment-13154019 ] Hudson commented on HADOOP-7833: -------------------------------- Integrated in Hadoop-Common-trunk-Commit #1296 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1296/]) HADOOP-7833. Fix findbugs warnings in protobuf generated code. Contributed by John Lee. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204363 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml > Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs > ---------------------------------------------------------------------------------------------------------------------------- > > Key: HADOOP-7833 > URL: https://issues.apache.org/jira/browse/HADOOP-7833 > Project: Hadoop Common > Issue Type: Bug > Reporter: John Lee > Assignee: John Lee > Fix For: 0.24.0 > > Attachments: HADOOP-7833.patch, HADOOP-7833.patch > > > findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java: > * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class > * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class > * UCF_USELESS_CONTROL_FLOW: Useless control flow > This can be fixed by adding the following findbugs exclude filter: > + > + > + > + > which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira