Return-Path: 
 <common-issues-return-22887-apmail-hadoop-common-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 40AFF7723
	for <apmail-hadoop-common-issues-archive@minotaur.apache.org>;
 Thu, 17 Nov 2011 23:46:14 +0000 (UTC)
Received: (qmail 96769 invoked by uid 500); 17 Nov 2011 23:46:14 -0000
Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org
Received: (qmail 96721 invoked by uid 500); 17 Nov 2011 23:46:14 -0000
Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:common-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:common-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:common-issues@hadoop.apache.org>
List-Id: <common-issues.hadoop.apache.org>
Reply-To: common-issues@hadoop.apache.org
Delivered-To: mailing list common-issues@hadoop.apache.org
Received: (qmail 96702 invoked by uid 99); 17 Nov 2011 23:46:13 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Nov 2011 23:46:13 +0000
X-ASF-Spam-Status: No, hits=-2001.2 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Nov 2011 23:46:12 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id BECFC8B4E3
	for <common-issues@hadoop.apache.org>; Thu, 17 Nov 2011 23:45:52 +0000 (UTC)
Date: Thu, 17 Nov 2011 23:45:52 +0000 (UTC)
From: "John Lee (Updated) (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <458351919.40895.1321573552783.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <760290213.40872.1321573311735.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (HADOOP-7833) Inner classes of
 org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
 which results in -1 for findbugs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Lee updated HADOOP-7833:
-----------------------------

    Status: Patch Available  (was: Open)
    
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7833
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7833
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: John Lee
>            Priority: Blocker
>         Attachments: HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> +    <Match>
> +      <!-- protobuf generated code -->
> +      <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> +    </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira